Skip to content

Clarified the bundle base template bit. #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Veltar
Copy link
Contributor

@Veltar Veltar commented Sep 3, 2014

No description provided.

@@ -408,6 +408,8 @@ lives in a specific location:
that's specific to the ``AcmeBlogBundle``. Since the middle, "controller",
portion is missing (e.g. ``Blog``), the template lives at
``Resources/views/layout.html.twig`` inside ``AcmeBlogBundle``.
Note that the colon is not removed with the "controller", and two colons exist
between the "bundle"name and template file name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle name and template filename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the note, but would re-word it to directly talk about the 2 colons:

Yes, there are 2 colons in the middle of the string when the "controller"
subdirectory part is missing.

@wouterj
Copy link
Member

wouterj commented Sep 8, 2014

I don't get what you are trying to say here, sorry. Can you maybe clarify your change a bit more? Was something confusing you in the current state?

@Veltar
Copy link
Contributor Author

Veltar commented Sep 8, 2014

Yes, it's a bit confusing that there are two colons in a row, it looks like a mistake if you don't have a lot of knowledge.

By know it seems logical to me, so maybe I was a bit premature in my edit.

weaverryan added a commit that referenced this pull request Oct 20, 2014
weaverryan added a commit that referenced this pull request Oct 20, 2014
* 2.3:
  [#4196] Updating language
  Clarified the bundle base template bit.
weaverryan added a commit that referenced this pull request Oct 20, 2014
* 2.5:
  [#4196] Updating language
  Clarified the bundle base template bit.
@weaverryan
Copy link
Member

Hi guys!

I think a little extra clarification here was kind of nice. So, I merged this, but updated the language a bit in sha: c8f96c0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants